linux-kernel - Re: [PATCH] pci: altera: remove unused 'node' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ac0565c-f920-4596-8ba0-91be892217c9@163.com>
Date: Thu, 22 May 2025 09:48:13 +0800
From: Hans Zhang <18255117159@....com>
To: Arnd Bergmann <arnd@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: Arnd Bergmann <arnd@...db.de>, Joyce Ooi <joyce.ooi@...el.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, "Jiri Slaby (SUSE)"
 <jirislaby@...nel.org>, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: altera: remove unused 'node' variable



On 2025/5/22 00:29, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This variable is only used when CONFIG_OF is enabled:
> 
> drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_init_irq_domain':
> drivers/pci/controller/pcie-altera.c:855:29: error: unused variable 'node' [-Werror=unused-variable]
>    855 |         struct device_node *node = dev->of_node;
> 
> Use dev_fwnode() in place of of_node_to_fwnode() to avoid this.
> 
> Fixes: bbc94e6f72f2 ("PCI: Switch to irq_domain_create_linear()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ----
> I checked the other PCI host bridge drivers as well, this is the
> only one with that problem.
> ---
>   drivers/pci/controller/pcie-altera.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> index 0fc77176a52e..3dbb7adc421c 100644
> --- a/drivers/pci/controller/pcie-altera.c
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -852,10 +852,9 @@ static void aglx_isr(struct irq_desc *desc)
>   static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
>   {
>   	struct device *dev = &pcie->pdev->dev;
> -	struct device_node *node = dev->of_node;
>   
>   	/* Setup INTx */
> -	pcie->irq_domain = irq_domain_create_linear(of_fwnode_handle(node), PCI_NUM_INTX,
> +	pcie->irq_domain = irq_domain_create_linear(dev_fwnode(dev), PCI_NUM_INTX,
>   					&intx_domain_ops, pcie);

Hello,

Please align the code by the way.

pcie->irq_domain = irq_domain_create_linear(dev_fwnode(dev), PCI_NUM_INTX,
					    &intx_domain_ops, pcie);


Besides, I didn't see this commit in the linux master branch and the PCI 
next branch.  It should be in some branch of Thomas Gleixner, right?

Fixes: bbc94e6f72f2 ("PCI: Switch to irq_domain_create_linear()")

Best regards,
Hans

>   	if (!pcie->irq_domain) {
>   		dev_err(dev, "Failed to get a INTx IRQ domain\n");