linux-kernel - Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC7lUE4kj8fnVVgM@shikoro>
Date: Thu, 22 May 2025 10:50:24 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Romain Gantois <romain.gantois@...tlin.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new()

On Wed, May 07, 2025 at 03:19:13PM +0300, Cosmin Tanislav wrote:
> In preparation for adding multiple flags that change the behavior,
> add a flags parameter to i2c_atr_new() and an i2c_atr_flags enum.
> 
> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> Reviewed-by: Romain Gantois <romain.gantois@...tlin.com>

How did you guys get it to build?

  CC      drivers/i2c/i2c-atr.o
In file included from drivers/i2c/i2c-atr.c:12:
./include/linux/i2c-atr.h:25:1: error: empty enum is invalid
   25 | };
      | ^
make[4]: *** [scripts/Makefile.build:203: drivers/i2c/i2c-atr.o] Error 1

I'll squash patches 7+8 to avoid it.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)