linux-kernel - RE: [PATCH v5 10/29] x86/resctrl: Change generic domain functions to use struct rdt_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083FBBCCA32EB8B94CCFDDEFC99A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Thu, 22 May 2025 00:15:06 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com>, Fenghua Yu
	<fenghuay@...dia.com>, "Chatre, Reinette" <reinette.chatre@...el.com>,
	"Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, "Chen, Yu C" <yu.c.chen@...el.com>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: RE: [PATCH v5 10/29] x86/resctrl: Change generic domain functions to
 use struct rdt_domain_hdr

> > @@ -597,25 +595,24 @@ static void domain_remove_cpu_ctrl(int cpu, struct rdt_resource *r)
> >     if (!domain_header_is_valid(hdr, RESCTRL_CTRL_DOMAIN, r->rid))
> >             return;
> >
> > +   cpumask_clear_cpu(cpu, &d->hdr.cpu_mask);
> Looks like variable 'd' is uninitialized when used here. Can you please
> check?

Good catch. I missed switching that to:

	cpumask_clear_cpu(cpu, &hdr->cpu_mask);

-Tony