[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6060a629-0fe5-4d66-8c37-7c9919a5548e@gmail.com>
Date: Thu, 22 May 2025 12:31:12 +0300
From: Cosmin Tanislav <demonsingur@...il.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Romain Gantois <romain.gantois@...tlin.com>, Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
Subject: Re: [PATCH v5 1/9] i2c: atr: Fix lockdep for nested ATRs
On 5/22/25 12:06 PM, Wolfram Sang wrote:
> On Wed, May 07, 2025 at 03:19:07PM +0300, Cosmin Tanislav wrote:
>> From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
>>
>> When we have an ATR, and another ATR as a subdevice of the first ATR,
>> we get lockdep warnings for the i2c_atr.lock and
>> i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key
>> for the locks, and doesn't see the locks of the separate ATR instances
>> as separate.
>>
>> Fix this by generating a dynamic lock key per lock instance.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
>> Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
>
> Your SoB is missing. I will add it for you if you confirm here.
>
My bad.
Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
Powered by blists - more mailing lists