linux-kernel - Re: [PATCH 2/2] ASoC: codecs: add support for ES8375

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50783a85-0515-47af-8486-a343e28f960a@sirena.org.uk>
Date: Thu, 22 May 2025 10:45:44 +0100
From: Mark Brown <broonie@...nel.org>
To: Zhang Yi <zhangyi@...rest-semi.com>
Cc: robh@...nel.org, tiwai@...e.com, devicetree@...r.kernel.org,
	conor+dt@...nel.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	perex@...ex.cz, krzk+dt@...nel.org,
	amadeuszx.slawinski@...ux.intel.com, krzk@...nel.org
Subject: Re: [PATCH 2/2] ASoC: codecs: add support for ES8375

On Thu, May 22, 2025 at 01:46:19PM +0800, Zhang Yi wrote:

> > > +	regmap_write(es8375->regmap, ES8375_ADC_VOLUME, 0xBF);
> > > +	regmap_write(es8375->regmap, ES8375_DAC_VOLUME, 0xBF);

> > Some of these settings look like they are (or should be) user
> > controllable and should be left at the chip defaults, the volumes above
> > really stand out.  We use chip defaults to avoid having to decide which
> > use cases to configure for.

> Because the default value of the chip's volume register is 0x00,
> initializing the device without setting it to 0xbf will
> cause the device to mute until the customer sets the volume.

That's normal and expected, it's totally fine and normal for the user to
have to do some configuration.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)