linux-kernel - Re: [PATCH] rust: list: Use "List::is_empty()" to perform checking when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DA2LIVGXSOVX.25YPFFEHM5CQB@kernel.org>
Date: Thu, 22 May 2025 11:52:56 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "I Hsin Cheng" <richard120310@...il.com>, <ojeda@...nel.org>
Cc: <alex.gaynor@...il.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, <benno.lossin@...ton.me>,
 <a.hindborg@...nel.org>, <aliceryhl@...gle.com>, <tmgross@...ch.edu>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <skhan@...uxfoundation.org>, <linux-kernel-mentees@...ts.linux.dev>,
 <jserv@...s.ncku.edu.tw>
Subject: Re: [PATCH] rust: list: Use "List::is_empty()" to perform checking
 when possible

On Mon Mar 10, 2025 at 8:38 AM CET, I Hsin Cheng wrote:
> "List::is_empty()" provides a straight forward convention to check
> whether a given "List" is empty or not. There're numerous places in the
> current implementation still use "self.first.is_null()" to perform the
> equivalent check, replace them with "List::is_empty()".
>
> Signed-off-by: I Hsin Cheng <richard120310@...il.com>
> ---
>  rust/kernel/list.rs | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Benno Lossin <lossin@...nel.org>

---
Cheers,
Benno