linux-kernel - Re: [PATCH] objtool/rust: relax slice condition to cover more `noreturn` Rust functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mPJDA55t=TGz3wFBBch9iPxjQ0V_CV30XR6XijWnh3dw@mail.gmail.com>
Date: Thu, 22 May 2025 11:55:46 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Alex Gaynor <alex.gaynor@...il.com>, Josh Poimboeuf <jpoimboe@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev, stable@...r.kernel.org, 
	John Hubbard <jhubbard@...dia.com>, Timur Tabi <ttabi@...dia.com>, Kane York <kanepyork@...il.com>, 
	Joel Fernandes <joelagnelf@...dia.com>
Subject: Re: [PATCH] objtool/rust: relax slice condition to cover more
 `noreturn` Rust functions

On Tue, May 20, 2025 at 8:56 PM Miguel Ojeda <ojeda@...nel.org> wrote:
>
> Developers are indeed hitting other of the `noreturn` slice symbols in
> Nova [1], thus relax the last check in the list so that we catch all of
> them, i.e.
>
>     *_4core5slice5index22slice_index_order_fail
>     *_4core5slice5index24slice_end_index_len_fail
>     *_4core5slice5index26slice_start_index_len_fail
>     *_4core5slice5index29slice_end_index_overflow_fail
>     *_4core5slice5index31slice_start_index_overflow_fail
>
> These all exist since at least Rust 1.78.0, thus backport it too.
>
> See commit 56d680dd23c3 ("objtool/rust: list `noreturn` Rust functions")
> for more details.
>
> Cc: stable@...r.kernel.org # Needed in 6.12.y and later.
> Cc: John Hubbard <jhubbard@...dia.com>
> Cc: Timur Tabi <ttabi@...dia.com>
> Cc: Kane York <kanepyork@...il.com>
> Cc: Josh Poimboeuf <jpoimboe@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Reported-by: Joel Fernandes <joelagnelf@...dia.com>
> Link: https://lore.kernel.org/rust-for-linux/20250513180757.GA1295002@joelnvbox/ [1]
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Applied to `rust-next` early so that others can benefit on -next --
thanks everyone!

    Fixes: 56d680dd23c3 ("objtool/rust: list `noreturn` Rust functions")

Cheers,
Miguel