linux-kernel - Re: [PATCH v2 2/6] ASoC: aoa: Use helper function for_each_child_of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fa189cfc0a52572008590efbf5f4ad05c81dbc6.camel@sipsolutions.net>
Date: Thu, 22 May 2025 12:04:23 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Ai Chao <aichao@...inos.cn>, perex@...ex.cz, tiwai@...e.com, 
	kuninori.morimoto.gx@...esas.com, lgirdwood@...il.com, broonie@...nel.org, 
	jbrunet@...libre.com, neil.armstrong@...aro.org, khilman@...libre.com, 
	martin.blumenstingl@...glemail.com, shengjiu.wang@...il.com,
 Xiubo.Lee@...il.com, 	festevam@...il.com, nicoleotsuka@...il.com,
 shawnguo@...nel.org, 	s.hauer@...gutronix.de, srinivas.kandagatla@...aro.org
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, linux-renesas-soc@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, 
	imx@...ts.linux.dev, kernel@...gutronix.de, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 2/6] ASoC: aoa: Use helper function
 for_each_child_of_node_scoped()

On Thu, 2025-05-22 at 13:02 +0800, Ai Chao wrote:
> The for_each_child_of_node_scoped() helper provides a scope-based
> clean-up functionality to put the device_node automatically, and
> as such, there is no need to call of_node_put() directly.
> 
> Thus, use this helper to simplify the code.

> -	for_each_child_of_node(dev->ofdev.dev.of_node, np) {
> +	for_each_child_of_node_scoped(dev->ofdev.dev.of_node, np) {
>  		if (of_device_is_compatible(np, "i2sbus") ||
>  		    of_device_is_compatible(np, "i2s-modem")) {
>  			got += i2sbus_add_dev(dev, control, np);

Given the structure of this code, this either fixes a leak, or is wrong.
I really don't know which of those two it is, it's been decades, but
either way it's not a change that simply "simplif[ies] the code".

johannes