linux-kernel - Re: [RFC PATCH v2] rust: list: Add examples for linked list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72n71k-KJ7krcOXL+fU0x+hU0vzrJTDNb-qT4rjR_JQ=OA@mail.gmail.com>
Date: Thu, 22 May 2025 12:05:22 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Benno Lossin <lossin@...nel.org>
Cc: I Hsin Cheng <richard120310@...il.com>, ojeda@...nel.org, alex.gaynor@...il.com, 
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	benno.lossin@...ton.me, a.hindborg@...nel.org, aliceryhl@...gle.com, 
	tmgross@...ch.edu, dakr@...nel.org, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev, jserv@...s.ncku.edu.tw
Subject: Re: [RFC PATCH v2] rust: list: Add examples for linked list

On Thu, May 22, 2025 at 11:52 AM Benno Lossin <lossin@...nel.org> wrote:
>
> This is a nice example, so
>
> Reviewed-by: Benno Lossin <lossin@...nel.org>
>
> It uses `unwrap` a lot, which might confuse newcomers that that is ok in
> normal code. I'm wondering if we can do something about that though...

Yeah, Danilo et al. mentioned this yesterday in the call.

I think it is not a big deal here since they are inside the
`assert*!`s (which one should not use anyway in normal code) -- the
other lines use `?`, which is good.

But as we discussed, I created a good first issue to tackle this for
both examples (since this one followed the cursor one):

    https://github.com/Rust-for-Linux/linux/issues/1164

I added your tag, by the way.

Cheers,
Miguel