linux-kernel - Re: [net PATCH 2/2] octeontx2-af: Fix APR entry mapping based on APR_LMT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a383c87-9c3d-4b61-b675-065d94f29a02@redhat.com>
Date: Thu, 22 May 2025 12:15:15 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Geethasowjanya Akula <gakula@...vell.com>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "kuba@...nel.org" <kuba@...nel.org>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>,
 Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Hariprasad Kelam <hkelam@...vell.com>
Subject: Re: [net PATCH 2/2] octeontx2-af: Fix APR entry mapping based on
 APR_LMT_CFG

On 5/21/25 2:07 PM, Geethasowjanya Akula wrote:
>> -----Original Message-----
>> From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>> Sent: Wednesday, May 21, 2025 2:06 PM
>>> @@ -568,8 +569,12 @@ static ssize_t
>> rvu_dbg_lmtst_map_table_display(struct file *filp,
>>>  		return -ENOMEM;
>>>
>>>  	tbl_base = rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_MAP_BASE);
>>> +	val  = rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_CFG);
>>> +	apr_vfs = 1 << (val & 0xF);
>>> +	apr_pfs = 1 << ((val >> 4) & 0x7);
>>>
>>> -	lmt_map_base = ioremap_wc(tbl_base, 128 * 1024);
>>> +	lmt_map_base = ioremap_wc(tbl_base, apr_pfs * apr_vfs *
>>> +				  LMT_MAPTBL_ENTRY_SIZE);
>>
>> As it is the same as in lmtst_map_table_ops() I think you can move whole to a
>> new function.
>>
>> rvu_ioremap_wc(rvu, base, size);
>>
>> or sth like that. It isn't strong opinion. Rest looks fine, thanks.
> Will address your suggestion in new patch along with other code enhancement.

FTR, I'm fine with a net-next follow-up.

Cheers,

Paolo