linux-kernel - Re: [PATCH v6 05/10] mfd: Add Apple Silicon System Management Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c9c2779e-dfa4-4e64-9b16-7558bb2563fd@app.fastmail.com>
Date: Thu, 22 May 2025 12:35:29 +0200
From: "Sven Peter" <sven@...npeter.dev>
To: "Lee Jones" <lee@...nel.org>
Cc: "Janne Grunau" <j@...nau.net>, "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
 "Neal Gompa" <neal@...pa.dev>, "Hector Martin" <marcan@...can.st>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Sebastian Reichel" <sre@...nel.org>,
 "Marc Zyngier" <maz@...nel.org>, "Russell King" <rmk+kernel@...linux.org.uk>,
 asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v6 05/10] mfd: Add Apple Silicon System Management Controller

Hi,


On Thu, May 22, 2025, at 10:59, Lee Jones wrote:
> On Thu, 15 May 2025, Sven Peter via B4 Relay wrote:
>
>> From: Sven Peter <sven@...npeter.dev>
>> 
>> The System Management Controller (SMC) on Apple Silicon machines is a
>> piece of hardware that exposes various functionalities such as
>> temperature sensors, voltage/power meters, shutdown/reboot handling,
>> GPIOs and more.
>> 
>> Communication happens via a shared mailbox using the RTKit protocol
>> which is also used for other co-processors. The SMC protocol then allows
>> reading and writing many different keys which implement the various
>> features. The MFD core device handles this protocol and exposes it
>> to the sub-devices.
>> 
>> Some of the sub-devices are potentially also useful on pre-M1 Apple
>> machines and support for SMCs on these machines can be added at a later
>> time.
>> 
>> Co-developed-by: Hector Martin <marcan@...can.st>
>> Signed-off-by: Hector Martin <marcan@...can.st>
>> Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
>> Reviewed-by: Neal Gompa <neal@...pa.dev>
>> Signed-off-by: Sven Peter <sven@...npeter.dev>
>> ---
>>  MAINTAINERS                |   2 +
>>  drivers/mfd/Kconfig        |  18 ++
>>  drivers/mfd/Makefile       |   1 +
>>  drivers/mfd/macsmc.c       | 498 +++++++++++++++++++++++++++++++++++++++++++++
>>  include/linux/mfd/macsmc.h | 279 +++++++++++++++++++++++++
>>  5 files changed, 798 insertions(+)
>
> Arghhh, so close!
>
> [...]
>
>> +static struct platform_driver apple_smc_driver = {
>> +	.driver = {
>> +		.name = "mfd-macsmc",
>
> Drop the 'mfd-' part please.

Ack.

>
>> +		.of_match_table = apple_smc_of_match,
>> +	},
>> +	.probe = apple_smc_probe,
>> +};
>> +module_platform_driver(apple_smc_driver);
>> +
>> +MODULE_AUTHOR("Hector Martin <marcan@...can.st>");
>> +MODULE_AUTHOR("Sven Peter <sven@...npeter.dev>");
>> +MODULE_LICENSE("Dual MIT/GPL");
>> +MODULE_DESCRIPTION("Apple SMC driver");
>
> I plan to apply this set after the merge-window.
>
> What else are you waiting on?

The only thing missing is a review/ack from the power/reset maintainers.
I will send v7 after the merge window rebased on -rc1 then.


Thanks,


Sven