linux-kernel - Re: [PATCH v1 2/2] ASoC: codecs: add support for ES8375

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77a6952e-5dc7-4889-9cb3-2d2ced48768e@sirena.org.uk>
Date: Thu, 22 May 2025 11:43:57 +0100
From: Mark Brown <broonie@...nel.org>
To: Zhang Yi <zhangyi@...rest-semi.com>
Cc: robh@...nel.org, tiwai@...e.com, devicetree@...r.kernel.org,
	conor+dt@...nel.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	perex@...ex.cz, krzk+dt@...nel.org,
	amadeuszx.slawinski@...ux.intel.com, krzk@...nel.org
Subject: Re: [PATCH v1 2/2] ASoC: codecs: add support for ES8375

On Thu, May 22, 2025 at 06:35:48PM +0800, Zhang Yi wrote:

Only a few very small things here:

> +static const struct snd_kcontrol_new es8375_snd_controls[] = {
> +	SOC_SINGLE_TLV("ADC OSR GAIN Volume", ES8375_ADC_OSR_GAIN,
> +			ADC_OSR_GAIN_SHIFT_0, ES8375_ADC_OSR_GAIN_MAX, 0,
> +			es8375_adc_osr_gain_tlv),

Probably just ADC OSR Volume.

> +	SOC_SINGLE_TLV("DMIC Gain Volume", ES8375_ADC1,
> +		DMIC_GAIN_SHIFT_2, ES8375_DMIC_GAIN_MAX,
> +		0, es8375_adc_dmic_volume_tlv),

Same here.

> +	SOC_SINGLE("ADC Automute Enable", ES8375_ADC_AUTOMUTE,
> +			ADC_AUTOMUTE_SHIFT_7, 1, 0),
> +
> +	SOC_SINGLE("DAC DSM Mute", ES8375_DAC1, DAC_DSMMUTE_SHIFT_7, 1, 0),
> +	SOC_SINGLE("DAC DEM Mute", ES8375_DAC1, DAC_DEMMUTE_SHIFT_6, 1, 0),

> +	SOC_SINGLE("DAC Automute Enable", ES8375_DAC_AUTOMUTE1,
> +			DAC_AUTOMUTE_EN_SHIFT_7, 1, 0),

These are all on/off switches so should be Switch.

> +	SOC_SINGLE_TLV("DAC Automute Attenuation", ES8375_DAC_AUTOMUTE,
> +			DAC_AUTOMUTE_ATTN_SHIFT_0, ES8375_DAC_AUTOMUTE_ATTN_MAX,
> +			0, es8375_dac_automute_attn_tlv),

This is also a Volume ("DAC Automute Volume").

> +	if (es8375->mclk_src == ES8375_BCLK_PIN) {
> +		if (es8375->mastermode) {
> +			dev_err(component->dev, "no mclk, cannot as master\n");
> +			return -EINVAL;
> +		}

Still got the outdated clocking terminology here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)