linux-kernel - Re: [PATCH v3] net/mlx5_core: Add error handling inmlx5_query_nic_vport_qkey_viol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250522111314.GP7435@unreal>
Date: Thu, 22 May 2025 14:13:14 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: saeedm@...dia.com, tariqt@...dia.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v3] net/mlx5_core: Add error handling
 inmlx5_query_nic_vport_qkey_viol_cntr()

On Wed, May 21, 2025 at 09:36:20PM +0800, Wentao Liang wrote:
> The function mlx5_query_nic_vport_qkey_viol_cntr() calls the function
> mlx5_query_nic_vport_context() but does not check its return value. This
> could lead to undefined behavior if the query fails. A proper
> implementation can be found in mlx5_nic_vport_query_local_lb().
> 
> Add error handling for mlx5_query_nic_vport_context(). If it fails, free
> the out buffer via kvfree() and return error code.
> 
> Fixes: 9efa75254593 ("net/mlx5_core: Introduce access functions to query vport RoCE fields")
> Cc: stable@...r.kernel.org # v4.5
> Target: net

"net" should be written in subject and not like keyword.
[PATCH v3] net/mlx5_core: Add error handling
->
[PATCH net v3] net/mlx5_core: Add error handling

Thanks