linux-kernel - Re: [PATCH v9 2/9] dma-buf: dma-heap: export declared functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a65f370-2df2-4169-85f9-c45e7c537447@amd.com>
Date: Thu, 22 May 2025 13:52:14 +0200
From: Christian König <christian.koenig@....com>
To: Jens Wiklander <jens.wiklander@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
 op-tee@...ts.trustedfirmware.org, linux-arm-kernel@...ts.infradead.org,
 Olivier Masse <olivier.masse@....com>,
 Thierry Reding <thierry.reding@...il.com>, Yong Wu <yong.wu@...iatek.com>,
 Sumit Semwal <sumit.semwal@...aro.org>,
 Benjamin Gaignard <benjamin.gaignard@...labora.com>,
 Brian Starkey <Brian.Starkey@....com>, John Stultz <jstultz@...gle.com>,
 "T . J . Mercier" <tjmercier@...gle.com>, Sumit Garg
 <sumit.garg@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 azarrabi@....qualcomm.com, Simona Vetter <simona.vetter@...ll.ch>,
 Daniel Stone <daniel@...ishbar.org>,
 Rouven Czerwinski <rouven.czerwinski@...aro.org>
Subject: Re: [PATCH v9 2/9] dma-buf: dma-heap: export declared functions

On 5/22/25 08:56, Jens Wiklander wrote:
> On Wed, May 21, 2025 at 9:13 AM Christian König
> <christian.koenig@....com> wrote:
>>
>> On 5/20/25 17:16, Jens Wiklander wrote:
>>> Export the dma-buf heap functions declared in <linux/dma-heap.h>.
>>
>> That is what this patch does and that should be obvious by looking at it. You need to explain why you do this.
>>
>> Looking at the rest of the series it's most likely ok, but this commit message should really be improved.
> 
> I'm considering something like this for the next version:
> Export the dma-buf heap functions declared in <linux/dma-heap.h> to allow
> them to be used by kernel modules. This will enable drivers like the OP-TEE
> driver, to utilize these interfaces for registering and managing their
> specific DMA heaps.

Works for me, but it doesn't needs to be so detailed.

Something like this here would be optimal I think:

Export the dma-buf heap functions to allow them to be used by the OP-TEE driver.
The OP-TEE driver wants to register and manage specific secure DMA heaps with it.

Regards,
Christian.

> 
> Thanks,
> Jens
> 
>>
>> Regards,
>> Christian.
>>
>>>
>>> Signed-off-by: Jens Wiklander <jens.wiklander@...aro.org>
>>> ---
>>>  drivers/dma-buf/dma-heap.c | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
>>> index 3cbe87d4a464..cdddf0e24dce 100644
>>> --- a/drivers/dma-buf/dma-heap.c
>>> +++ b/drivers/dma-buf/dma-heap.c
>>> @@ -202,6 +202,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap)
>>>  {
>>>       return heap->priv;
>>>  }
>>> +EXPORT_SYMBOL(dma_heap_get_drvdata);
>>>
>>>  /**
>>>   * dma_heap_get_name - get heap name
>>> @@ -214,6 +215,7 @@ const char *dma_heap_get_name(struct dma_heap *heap)
>>>  {
>>>       return heap->name;
>>>  }
>>> +EXPORT_SYMBOL(dma_heap_get_name);
>>>
>>>  /**
>>>   * dma_heap_add - adds a heap to dmabuf heaps
>>> @@ -303,6 +305,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info)
>>>       kfree(heap);
>>>       return err_ret;
>>>  }
>>> +EXPORT_SYMBOL(dma_heap_add);
>>>
>>>  static char *dma_heap_devnode(const struct device *dev, umode_t *mode)
>>>  {
>>