linux-kernel - Re: [PATCH net] net: phy: clear phydev->devlink when the link is deleted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f19659d4-444c-4f44-9bff-4c83a8c5a7e9@lunn.ch>
Date: Thu, 22 May 2025 14:33:32 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Wei Fang <wei.fang@....com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	f.fainelli@...il.com, xiaolei.wang@...driver.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev
Subject: Re: [PATCH net] net: phy: clear phydev->devlink when the link is
 deleted

On Thu, May 22, 2025 at 02:42:53PM +0800, Wei Fang wrote:
> The phydev->devlink is not cleared when the link is deleted, so calling
> phy_detach() again will cause a crash.

I would say crashing is correct. You have done something you should
not do, and the crash helped you find it. phy_attach() and
phy_detach() should always be in pairs.

    Andrew

---
pw-bot: cr