linux-kernel - Re: [PATCH v2] arm: Fix rustgcc unknown argument '-mno-fdpic'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mh1h8d-EWrZef=BPPtadZyHG0B+tg9GgA_RnWiETWMkA@mail.gmail.com>
Date: Thu, 22 May 2025 14:52:32 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Rudraksha Gupta <guptarud@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, 
	torvalds@...ux-foundation.org, Ben Wolsieffer <ben.wolsieffer@...ring.com>, 
	Naresh Kamboju <naresh.kamboju@...aro.org>, Christian Schrrefl <chrisi.schrefl@...il.com>, 
	Russell King <rmk+kernel@...linux.org.uk>, Ard Biesheuvel <ardb@...nel.org>, anders.roxell@...aro.org, 
	arnd@...db.de, dan.carpenter@...aro.org, laura.nao@...labora.com, 
	lkft-triage@...ts.linaro.org, regressions@...ts.linux.dev, 
	Nick Clifton <nickc@...hat.com>, Richard Earnshaw <richard.earnshaw@....com>, 
	Ramana Radhakrishnan <ramanara@...dia.com>, Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH v2] arm: Fix rustgcc unknown argument '-mno-fdpic'

On Thu, May 22, 2025 at 2:02 PM Rudraksha Gupta <guptarud@...il.com> wrote:
>
> Currently rust on arm fails to compile due to '-mno-fdpic'. This flag
> disables a GCC feature that we don't want for kernel builds, so let's
> skip it as it doesn't apply to Clang.
>
>     UPD     include/generated/asm-offsets.h
>     CALL    scripts/checksyscalls.sh
>     RUSTC L rust/core.o
>     BINDGEN rust/bindings/bindings_generated.rs
>     BINDGEN rust/bindings/bindings_helpers_generated.rs
>     CC      rust/helpers/helpers.o
>     Unable to generate bindings: clang diagnosed error: error: unknown argument: '-mno-fdpic'
>     make[2]: *** [rust/Makefile:369: rust/bindings/bindings_helpers_generated.rs] Error 1
>     make[2]: *** Deleting file 'rust/bindings/bindings_helpers_generated.rs'
>     make[2]: *** Waiting for unfinished jobs....
>     Unable to generate bindings: clang diagnosed error: error: unknown argument: '-mno-fdpic'
>     make[2]: *** [rust/Makefile:349: rust/bindings/bindings_generated.rs] Error 1
>     make[2]: *** Deleting file 'rust/bindings/bindings_generated.rs'
>     make[1]: *** [/home/pmos/build/src/linux-next-next-20250521/Makefile:1285: prepare] Error 2
>     make: *** [Makefile:248: __sub-make] Error 2
>
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Closes: https://lore.kernel.org/all/CA+G9fYvOanQBYXKSg7C6EU30k8sTRC0JRPJXYu7wWK51w38QUQ@mail.gmail.com/
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Tested-by: Rudraksha Gupta <guptarud@...il.com>
> Acked-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Signed-off-by: Rudraksha Gupta <guptarud@...il.com>

Thanks for sending a v2! I was going to fix it myself, but this is
even better :)

By the way, submitting a patch typically requires / generally implies
that you actually tested it, so your own Tested-by is usually not
provided.

Cheers,
Miguel