linux-kernel - Re: [PATCH net-next] net: phy: Synchronize c45_ids to phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC8l-96fjjPBvYS1@shell.armlinux.org.uk>
Date: Thu, 22 May 2025 14:26:19 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Synchronize c45_ids to phy_id

On Thu, May 22, 2025 at 09:19:18PM +0800, Yajun Deng wrote:
> The phy_id_show() function emit the phy_id for the phy device. If the phy
> device is a c45 device, the phy_id is empty. In other words, phy_id_show()
> only works with the c22 device.

This is correct.

> Synchronize c45_ids to phy_id, phy_id_show() will work with both the c22
> and c45 devices.

This is incorrect, as there may (and are in some cases) be multiple
different IDs in a C45 PHY.

I think we've had patches like this before and turned them down.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!