linux-kernel - Re: [PATCH] thermal: qcom: ipq5018: make ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hKVGFG_wY+HukbG97J4QQA7ab=KjBMqu9EZCsqEOHsog@mail.gmail.com>
Date: Fri, 23 May 2025 17:18:44 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, george.moussalem@...look.com
Cc: Amit Kucheria <amitk@...nel.org>, Thara Gopinath <thara.gopinath@...il.com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, linux-pm@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] thermal: qcom: ipq5018: make ops_ipq5018 struct static

On Thu, May 22, 2025 at 2:46 PM Dmitry Baryshkov
<dmitry.baryshkov@....qualcomm.com> wrote:
>
> On Thu, May 22, 2025 at 09:48:51AM +0400, George Moussalem via B4 Relay wrote:
> > From: George Moussalem <george.moussalem@...look.com>
> >
> > Fix a sparse warning by making the ops_ipq5018 struct static.
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202505202356.S21Sc7bk-lkp@intel.com/
> > Signed-off-by: George Moussalem <george.moussalem@...look.com>
> > ---
> > Fix below sparse warning by making the ops_ipq5018 struct static.
> >
> > sparse warnings: (new ones prefixed by >>)
> > >> drivers/thermal/qcom/tsens-v1.c:246:24: sparse: sparse: symbol 'ops_ipq5018' was not declared. Should it be static?
> >
> > vim +/ops_ipq5018 +246 drivers/thermal/qcom/tsens-v1.c
> >
> >    245
> >  > 246        const struct tsens_ops ops_ipq5018 = {
> >    247                .init           = init_tsens_v1_no_rpm,
> >    248                .calibrate      = tsens_calibrate_common,
> >    249                .get_temp       = get_temp_tsens_valid,
> >    250        };
> >    251
> > ---
> >  drivers/thermal/qcom/tsens-v1.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixes: 04b31cc53fe0 ("thermal/drivers/qcom/tsens: Add support for IPQ5018 tsens")
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>

Applied as 6.16 material, thanks!