linux-kernel - Re: [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string adi,adt7411

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e11aade8-f646-4d94-942c-6186f06fe783@roeck-us.net>
Date: Fri, 23 May 2025 09:02:12 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Conor Dooley <conor@...nel.org>, Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Noah Wang <noahwang.wang@...look.com>,
 Naresh Solanki <naresh.solanki@...ements.com>,
 Michal Simek <michal.simek@....com>, Fabio Estevam <festevam@...il.com>,
 Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>,
 Grant Peltier <grantpeltier93@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string
 adi,adt7411

On 5/23/25 08:30, Conor Dooley wrote:
> On Fri, May 23, 2025 at 11:13:37AM -0400, Frank Li wrote:
>> Add compatible string adi,adt7411, which is temperature sensor and
>> 8-Channel ADC.
> 
> Usually for iio devices supplies are meant to be documented, and this
> device has one.
> 

FWIW, the driver supporting this chip is some 15 years old. I don't think
anyone was talking about supplies at that time.

Also, this is currently implemented as hwmon driver. Is there an effort
to move the driver out of hwmon and into iio ? Fine with me if this is
where things are going (one less driver to maintain), but I would caution
that this will result in an ABI break for users of the hwmon driver.

Thanks,
Guenter

>>
>> Fix below CHECK_DTB warning:
>>
>> arch/arm/boot/dts/nxp/vf/vf610-zii-scu4-aib.dtb: /soc/bus@...80000/i2c@...e6000/adc@4a:
>>      failed to match any schema with compatible: ['adi,adt7411']
>>
>> Signed-off-by: Frank Li <Frank.Li@....com>
>> ---
>>   Documentation/devicetree/bindings/trivial-devices.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 27930708ccd58..38bc1937ff3c9 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -41,6 +41,7 @@ properties:
>>             - adi,ad5110
>>               # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
>>             - adi,adp5589
>> +          - adi,adt7411 # Temperature Sensor and 8-Channel ADC
>>               # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
>>             - adi,lt7182s
>>               # AMS iAQ-Core VOC Sensor
>> -- 
>> 2.34.1
>>