linux-kernel - RE: [PATCH v5 1/3] ACPI/MRRM: Minimal parse of ACPI MRRM table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083AA31D763B103D8296438FC98A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Fri, 23 May 2025 16:26:38 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com>,
	"rafael@...nel.org" <rafael@...nel.org>
CC: "lenb@...nel.org" <lenb@...nel.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: RE: [PATCH v5 1/3] ACPI/MRRM: Minimal parse of ACPI MRRM table

> diff --git a/drivers/acpi/acpi_mrrm.c b/drivers/acpi/acpi_mrrm.c
> new file mode 100644
> index 000000000000..ab8022e58da5
> --- /dev/null
> +++ b/drivers/acpi/acpi_mrrm.c
> @@ -0,0 +1,42 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2025, Intel Corporation.
> + *
> + * Memory Range and Region Mapping (MRRM) structure
> + */
> +
> +#define pr_fmt(fmt) "acpi/mrrm: " fmt
> +
> +#include <linux/acpi.h>
> +#include <linux/init.h>
> +
> +static int max_mem_region = -ENOENT;
> This should be initialized to 1 instead of -ENOENT(-2).
> Per the spec, sec 5.1, if platform does not define MRRM, it says, SW may assume that only one memory region is defined.
>
> +
> +/* Access for use by resctrl file system */
> +int acpi_mrrm_max_mem_region(void)
> +{
> +     return max_mem_region;
> +}
> In which case this function will return a minimum of 1 region as max_mem_region of -2 has no meaning.
> When resctrl file system calls this function, it expects at least one region exists.

[Replying to HTML e-mail that will have been dropped from LKML and other lists]

Anil,

Rafael has this queued for next merge window. Please send a patch to
fix the issues you found.

Thanks

-Tony