linux-kernel - Re: [PATCH next] drm/panel: nt37801: Fix IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdd44c38-24dc-4775-88cd-c96696e6bb4b@quicinc.com>
Date: Fri, 23 May 2025 09:31:29 -0700
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>
CC: Krzysztof Kozlowski <krzk@...nel.org>,
        Neil Armstrong
	<neil.armstrong@...aro.org>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Linus Walleij <linus.walleij@...aro.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] drm/panel: nt37801: Fix IS_ERR() vs NULL check in
 probe()



On 5/23/2025 9:09 AM, Dan Carpenter wrote:
> The devm_drm_panel_alloc() function returns error pointers, it doesn't
> return NULL.  Update the check to match.
> 
> Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Jessica Zhang <quic_jesszhan@...cinc.com>

> ---
>   drivers/gpu/drm/panel/panel-novatek-nt37801.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt37801.c b/drivers/gpu/drm/panel/panel-novatek-nt37801.c
> index 84d367eab058..d6a37d7e0cc6 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt37801.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt37801.c
> @@ -257,8 +257,8 @@ static int novatek_nt37801_probe(struct mipi_dsi_device *dsi)
>   	ctx = devm_drm_panel_alloc(dev, struct novatek_nt37801, panel,
>   				   &novatek_nt37801_panel_funcs,
>   				   DRM_MODE_CONNECTOR_DSI);
> -	if (!ctx)
> -		return -ENOMEM;
> +	if (IS_ERR(ctx))
> +		return PTR_ERR(ctx);
>   
>   	ret = devm_regulator_bulk_get_const(dev,
>   					    ARRAY_SIZE(novatek_nt37801_supplies),