linux-kernel - Re: [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string adi,adt7411

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250523-enactment-basics-ceb5ae318611@spud>
Date: Fri, 23 May 2025 17:37:31 +0100
From: Conor Dooley <conor@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Noah Wang <noahwang.wang@...look.com>,
	Naresh Solanki <naresh.solanki@...ements.com>,
	Michal Simek <michal.simek@....com>,
	Fabio Estevam <festevam@...il.com>,
	Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>,
	Grant Peltier <grantpeltier93@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string
 adi,adt7411

On Fri, May 23, 2025 at 09:02:12AM -0700, Guenter Roeck wrote:
> On 5/23/25 08:30, Conor Dooley wrote:
> > On Fri, May 23, 2025 at 11:13:37AM -0400, Frank Li wrote:
> > > Add compatible string adi,adt7411, which is temperature sensor and
> > > 8-Channel ADC.
> > 
> > Usually for iio devices supplies are meant to be documented, and this
> > device has one.
> > 
> 
> FWIW, the driver supporting this chip is some 15 years old. I don't think
> anyone was talking about supplies at that time.

That extra context is helpful.

> Also, this is currently implemented as hwmon driver. Is there an effort
> to move the driver out of hwmon and into iio ? Fine with me if this is
> where things are going (one less driver to maintain), but I would caution
> that this will result in an ABI break for users of the hwmon driver.

What subsystem doesn't really matter, particularly the difference
between what is a hwmon or not seems to be up to the whims of the first
submitter for some devices. I don't know anything about moving drivers
or w/e, I am literally just reviewing this one patch that landed in my
inbox that had a supply missing.

If this is some 15 year old device, then I can live without the supply
I suppose.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Really trivial-devices should have an optional supply in it, if someone
comes along with a generic name for that supply..

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)