linux-kernel - Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd22525a-dd4c-47b0-8cd0-52c0e8c64ca6@linuxfoundation.org>
Date: Fri, 23 May 2025 12:46:24 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Brigham Campbell <me@...ghamcampbell.com>,
 linux-kernel-mentees@...ts.linux.dev, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
 "H. Peter Anvin" <hpa@...or.com>, Shuah Khan <shuah@...nel.org>,
 "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
 <linux-kernel@...r.kernel.org>,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message

On 5/23/25 01:32, Brigham Campbell wrote:
> Apparently, this test completes successfully when it completes execution
> without either causing a kernel panic or being killed by the kernel.
> This new test result message is more descriptive and grammatically
> correct.
> 

The change log description usually is in imperative - e.g:

"Change test result message to be more descriptive and grammatically
correct.."

> There are no changes in v2. I'm resending this patch because I addressed
> it to the wrong email for Shuah.

Version change information goes under the --- after the Signed-off-by

> 
> Signed-off-by: Brigham Campbell <me@...ghamcampbell.com>
> ---
>   tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/x86/mov_ss_trap.c b/tools/testing/selftests/x86/mov_ss_trap.c
> index f22cb6b382f9..d80033c0d7eb 100644
> --- a/tools/testing/selftests/x86/mov_ss_trap.c
> +++ b/tools/testing/selftests/x86/mov_ss_trap.c
> @@ -269,6 +269,6 @@ int main()
>   			);
>   	}
>   
> -	printf("[OK]\tI aten't dead\n");
> +	printf("[OK]\tkernel handled MOV SS without crashing test\n");
>   	return 0;
>   }

thanks,
-- Shuah