linux-kernel - Re: [PATCH 3/3] net: ipa: Grab IMEM slice base/size from DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505240200.w0D4DdAY-lkp@intel.com>
Date: Sat, 24 May 2025 02:59:48 +0800
From: kernel test robot <lkp@...el.com>
To: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Alex Elder <elder@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH 3/3] net: ipa: Grab IMEM slice base/size from DTS

Hi Konrad,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 460178e842c7a1e48a06df684c66eb5fd630bcf7]

url:    https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/dt-bindings-sram-qcom-imem-Allow-modem-tables/20250523-071359
base:   460178e842c7a1e48a06df684c66eb5fd630bcf7
patch link:    https://lore.kernel.org/r/20250523-topic-ipa_imem-v1-3-b5d536291c7f%40oss.qualcomm.com
patch subject: [PATCH 3/3] net: ipa: Grab IMEM slice base/size from DTS
config: xtensa-randconfig-002-20250524 (https://download.01.org/0day-ci/archive/20250524/202505240200.w0D4DdAY-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250524/202505240200.w0D4DdAY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505240200.w0D4DdAY-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ipa/ipa_mem.c: In function 'ipa_mem_init':
>> drivers/net/ipa/ipa_mem.c:623:17: warning: variable 'imem_size' set but not used [-Wunused-but-set-variable]
     u32 imem_base, imem_size;
                    ^~~~~~~~~
>> drivers/net/ipa/ipa_mem.c:623:6: warning: variable 'imem_base' set but not used [-Wunused-but-set-variable]
     u32 imem_base, imem_size;
         ^~~~~~~~~


vim +/imem_size +623 drivers/net/ipa/ipa_mem.c

   616	
   617	/* Perform memory region-related initialization */
   618	int ipa_mem_init(struct ipa *ipa, struct platform_device *pdev,
   619			 const struct ipa_mem_data *mem_data)
   620	{
   621		struct device_node *ipa_slice_np;
   622		struct device *dev = &pdev->dev;
 > 623		u32 imem_base, imem_size;
   624		struct resource *res;
   625		int ret;
   626	
   627		/* Make sure the set of defined memory regions is valid */
   628		if (!ipa_mem_valid(ipa, mem_data))
   629			return -EINVAL;
   630	
   631		ipa->mem_count = mem_data->local_count;
   632		ipa->mem = mem_data->local;
   633	
   634		/* Check the route and filter table memory regions */
   635		if (!ipa_table_mem_valid(ipa, false))
   636			return -EINVAL;
   637		if (!ipa_table_mem_valid(ipa, true))
   638			return -EINVAL;
   639	
   640		ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
   641		if (ret) {
   642			dev_err(dev, "error %d setting DMA mask\n", ret);
   643			return ret;
   644		}
   645	
   646		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ipa-shared");
   647		if (!res) {
   648			dev_err(dev,
   649				"DT error getting \"ipa-shared\" memory property\n");
   650			return -ENODEV;
   651		}
   652	
   653		ipa->mem_virt = memremap(res->start, resource_size(res), MEMREMAP_WC);
   654		if (!ipa->mem_virt) {
   655			dev_err(dev, "unable to remap \"ipa-shared\" memory\n");
   656			return -ENOMEM;
   657		}
   658	
   659		ipa->mem_addr = res->start;
   660		ipa->mem_size = resource_size(res);
   661	
   662		ipa_slice_np = of_parse_phandle(dev->of_node, "sram", 0);
   663		if (ipa_slice_np) {
   664			ret = of_address_to_resource(ipa_slice_np, 0, res);
   665			of_node_put(ipa_slice_np);
   666			if (ret)
   667				return ret;
   668	
   669			imem_base = res->start;
   670			imem_size = resource_size(res);
   671		} else {
   672			/* Backwards compatibility for DTs lacking an explicit reference */
   673			imem_base = mem_data->imem_addr;
   674			imem_size = mem_data->imem_size;
   675		}
   676	
   677		ret = ipa_imem_init(ipa, mem_data->imem_addr, mem_data->imem_size);
   678		if (ret)
   679			goto err_unmap;
   680	
   681		ret = ipa_smem_init(ipa, mem_data->smem_size);
   682		if (ret)
   683			goto err_imem_exit;
   684	
   685		return 0;
   686	
   687	err_imem_exit:
   688		ipa_imem_exit(ipa);
   689	err_unmap:
   690		memunmap(ipa->mem_virt);
   691	
   692		return ret;
   693	}
   694	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki