linux-kernel - Re: [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <334404bdf60765cb5a8e855a74c688bc537531ee.camel@nvidia.com>
Date: Fri, 23 May 2025 20:18:17 +0000
From: Timur Tabi <ttabi@...dia.com>
To: Ben Skeggs <bskeggs@...dia.com>, "dan.carpenter@...aro.org"
	<dan.carpenter@...aro.org>
CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"airlied@...hat.com" <airlied@...hat.com>, Jon Hunter <jonathanh@...dia.com>,
	"lyude@...hat.com" <lyude@...hat.com>, "baolu.lu@...ux.intel.com"
	<baolu.lu@...ux.intel.com>, "simona@...ll.ch" <simona@...ll.ch>,
	"airlied@...il.com" <airlied@...il.com>, "thierry.reding@...il.com"
	<thierry.reding@...il.com>, "dakr@...nel.org" <dakr@...nel.org>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH next] drm/nouveau/tegra: Fix error pointer vs NULL return
 in nvkm_device_tegra_resource_addr()

On Fri, 2025-05-23 at 19:07 +0300, Dan Carpenter wrote:
> The nvkm_device_tegra_resource() function returns a mix of error pointers
> and NULL.  The callers only expect it to return NULL on error.  Change it
> to only return NULL.
> 
> Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Timur Tabi <ttabi@...dia.com>