linux-kernel - Re: [RFC] selftests/mm: Skip tests dependent on a binary not built

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73101285-2854-470e-a3bb-9a363a7c1991@gmail.com>
Date: Sat, 24 May 2025 00:33:08 +0300
From: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>, linux-mm@...ck.org
Cc: linux-kernel-mentees@...ts.linux.dev, akpm@...ux-foundation.org,
 shuah@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC] selftests/mm: Skip tests dependent on a binary not built

On 24/05/2025 12:09 am, Shuah Khan wrote:
> On 5/23/25 12:43, Khaled Elnaggar wrote:
>> Hello.
>>
> 
> The above doesn't belong in change log. Refer to a few change logs
> in the repo to learn  how to write them.
> 
> You can also check the kernel documentation - this change log
> is way too long. It doesn't clearly state what is being fixed.
> 
> In this case, "write_to_hugetlbfs" is missing because the right
> config isn't enabled. Test stalls waiting for write_to_hugetlbfs
> to run.
> 
> You are fixing this by checking if write_to_hugetlbfs exixts
> from /mm/run_vmtests.sh
> 
> Summarize this in short description so people can understand
> the change.
> 
> thanks,
> -- Shuah

Oh, I mistakenly thought since RFC does not get merged into source tree, 
it could have a relaxed tone, hence the much text.

Appreciate your feedback, I will rewrite the patch considering the
points mentioned. Thank you.