linux-kernel - Re: [PATCH 01/18] media: coda: Add print if irq isn't present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8558fbb295be82e2288750048aba1a1dbc396093.camel@ndufresne.ca>
Date: Fri, 23 May 2025 19:43:37 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Sergey Khimich <serghox@...il.com>, linux-media@...r.kernel.org
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Mauro Carvalho Chehab
	 <mchehab@...nel.org>, linux-kernel@...r.kernel.org, Vladimir Yakovlev
	 <vovchkir@...il.com>, Maksim Turok <turok.m7@...il.com>
Subject: Re: [PATCH 01/18] media: coda: Add print if irq isn't present

Le vendredi 23 mai 2025 à 19:40 -0400, Nicolas Dufresne a écrit :
> Hi,
> 
> Le vendredi 14 mars 2025 à 18:29 +0300, Sergey Khimich a écrit :
> > From: Vladimir Yakovlev <vovchkir@...il.com>
> > 
> > Use dev_err_probe for print and return error if irq isn't present
> > 
> > Co-developed-by: Sergey Khimich <serghox@...il.com>
> > Signed-off-by: Sergey Khimich <serghox@...il.com>
> > Signed-off-by: Vladimir Yakovlev <vovchkir@...il.com>
> 
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

Please don't forget to move Vladimir SoB first in v2, while adding
this Rb. This applies to most of your patches.

Nicolas

> 
> > ---
> >  drivers/media/platform/chips-media/coda/coda-common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-
> > common.c
> > index 289a076c3bcc..84b9b75b382e 100644
> > --- a/drivers/media/platform/chips-media/coda/coda-common.c
> > +++ b/drivers/media/platform/chips-media/coda/coda-common.c
> > @@ -3178,7 +3178,7 @@ static int coda_probe(struct platform_device *pdev)
> >  	if (irq < 0)
> >  		irq = platform_get_irq(pdev, 0);
> >  	if (irq < 0)
> > -		return irq;
> > +		return dev_err_probe(&pdev->dev, irq, "Failed to get irq 0 (bit)\n");
> >  
> >  	ret = devm_request_irq(&pdev->dev, irq, coda_irq_handler, 0,
> >  			       CODA_NAME "-video", dev);