linux-kernel - Re: [PATCH] mmu_notifiers: remove leftover stub macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cdf967f-9606-4d12-9ea3-140f9bffe516@bytedance.com>
Date: Fri, 23 May 2025 11:43:30 +0800
From: Qi Zheng <zhengqi.arch@...edance.com>
To: Jann Horn <jannh@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Alistair Popple <apopple@...dia.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH] mmu_notifiers: remove leftover stub macros



On 5/23/25 6:30 AM, Jann Horn wrote:
> Commit ec8832d007cb ("mmu_notifiers: don't invalidate secondary TLBs as
> part of mmu_notifier_invalidate_range_end()") removed the main definitions
> of {ptep,pmdp_huge,pudp_huge}_clear_flush_notify; just their
> !CONFIG_MMU_NOTIFIER stubs are left behind, remove them.
> 
> Signed-off-by: Jann Horn <jannh@...gle.com>
> ---
>   include/linux/mmu_notifier.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
> index bc2402a45741..d1094c2d5fb6 100644
> --- a/include/linux/mmu_notifier.h
> +++ b/include/linux/mmu_notifier.h
> @@ -654,9 +654,6 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm)
>   #define pmdp_clear_flush_young_notify pmdp_clear_flush_young
>   #define ptep_clear_young_notify ptep_test_and_clear_young
>   #define pmdp_clear_young_notify pmdp_test_and_clear_young
> -#define	ptep_clear_flush_notify ptep_clear_flush
> -#define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush
> -#define pudp_huge_clear_flush_notify pudp_huge_clear_flush

Reviewed-by: Qi Zheng <zhengqi.arch@...edance.com>

Thanks!

>   
>   static inline void mmu_notifier_synchronize(void)
>   {
> 
> ---
> base-commit: e85dea591fbf900330c796579314bfb7cc399d31
> change-id: 20250523-mmu-notifier-cleanup-unused-238762302a66
>