linux-kernel - Re: [PATCH] platform/x86/amd/hsmp: fix building with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35537263-47cf-4cc3-9808-7a93361d3ba8@amd.com>
Date: Fri, 23 May 2025 09:42:07 +0530
From: Suma Hegde <Suma.Hegde@....com>
To: Arnd Bergmann <arnd@...nel.org>,
 Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Arnd Bergmann <arnd@...db.de>, Carlos Bilbao <carlos.bilbao@...nel.org>,
 Yazen Ghannam <yazen.ghannam@....com>, "Borislav Petkov (AMD)"
 <bp@...en8.de>, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/amd/hsmp: fix building with CONFIG_HWMON=m

Hi Arnd,


On 5/22/2025 8:08 PM, Arnd Bergmann wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> From: Arnd Bergmann <arnd@...db.de>
>
> When CONFIG_HWMON is built as a loadable module, the HSMP drivers
> cannot be built-in:
>
> ERROR: modpost: "hsmp_create_sensor" [drivers/platform/x86/amd/hsmp/amd_hsmp.ko] undefined!
> ERROR: modpost: "hsmp_create_sensor" [drivers/platform/x86/amd/hsmp/hsmp_acpi.ko] undefined!
>
> Enforce that through the usual Kconfig dependnecy trick.
>
> Fixes: 92c025db52bb ("platform/x86/amd/hsmp: Report power via hwmon sensors")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/platform/x86/amd/hsmp/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/amd/hsmp/Kconfig b/drivers/platform/x86/amd/hsmp/Kconfig
> index d6f7a62d55b5..2911120792e8 100644
> --- a/drivers/platform/x86/amd/hsmp/Kconfig
> +++ b/drivers/platform/x86/amd/hsmp/Kconfig
> @@ -12,6 +12,7 @@ menu "AMD HSMP Driver"
>   config AMD_HSMP_ACPI
>          tristate "AMD HSMP ACPI device driver"
>          depends on ACPI
> +       depends on HWMON || !HWMON


Thanks for sending this fix.  I verified it.

Along with this  fix, I will change IS_REACHABLE() to IS_ENABLED() in 
hsmp.h as its not necessary and send v2 of this patch.

-#if IS_REACHABLE(CONFIG_HWMON)
+#if IS_ENABLED(CONFIG_HWMON)
  int hsmp_create_sensor(struct device *dev, u16 sock_ind);
  #else
static inline int hsmp_create_sensor(struct device *dev, u16 sock_ind) { 
return 0; }
#endif

>          select AMD_HSMP
>          help
>            Host System Management Port (HSMP) interface is a mailbox interface
> @@ -29,6 +30,7 @@ config AMD_HSMP_ACPI
>
>   config AMD_HSMP_PLAT
>          tristate "AMD HSMP platform device driver"
> +       depends on HWMON || !HWMON
>          select AMD_HSMP
>          help
>            Host System Management Port (HSMP) interface is a mailbox interface
> --
> 2.39.5


Thanks and Regards,

Suma