linux-kernel - Re: [PATCH v2 1/1] Revert "ARM: dts: Update pcie ranges for dra7"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a8a4f18-d5cc-4fd1-aeda-2e739502e0eb@ti.com>
Date: Fri, 23 May 2025 11:02:38 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Frank Li <Frank.li@....com>
CC: <s-vadapalli@...com>, <bhelgaas@...gle.com>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <krzk+dt@...nel.org>, <kw@...ux.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <lpieralisi@...nel.org>, <manivannan.sadhasivam@...aro.org>,
        <robh@...nel.org>, <tony@...mide.com>, <vigneshr@...com>
Subject: Re: [PATCH v2 1/1] Revert "ARM: dts: Update pcie ranges for dra7"

On Thu, May 22, 2025 at 03:29:34PM -0400, Frank Li wrote:

Hello Frank,

> On Fri, Apr 11, 2025 at 11:34:54AM -0400, Frank Li wrote:
> > This reverts commit c761028ef5e27f477fe14d2b134164c584fc21ee.
> >
> > The commit being reverted updated the "ranges" property for the sake of
> > readability. However, this change is no longer appropriate due to the
> > following reasons:
> >
> > - On many SoCs, the PCIe parent bus translates CPU addresses to different
> > values before passing them to the PCIe controller.
> > - The reverted commit introduced a fake address translation, which violates
> > the fundamental DTS principle: the device tree should reflect actual
> > hardware behavior.
> >
> > Reverting this change prepares for the cleanup of the driver's
> > cpu_addr_fixup() hook.
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> 
> s-vadapalli:
> 
> 	Any update about this patch? it prepare to remove cpu_addr_fixes()!

This patch looks good to me, but I was hoping that Tony Lindgren, who is
the author of the commit being reverted, would provide feedback as well.

Regards,
Siddharth.