linux-kernel - RE: [PATCH v4 0/2] livepatch, arm64/module: Enable late module relocations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY4PR01MB13777AB3A12DCA297E5642CEDD798A@TY4PR01MB13777.jpnprd01.prod.outlook.com>
Date: Fri, 23 May 2025 05:55:05 +0000
From: "Toshiyuki Sato (Fujitsu)" <fj6611ie@...itsu.com>
To: 'Dylan Hatch' <dylanbhatch@...gle.com>
CC: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>, Josh
 Poimboeuf <jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>, Miroslav
 Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>, Joe Lawrence
	<joe.lawrence@...hat.com>, Song Liu <song@...nel.org>, Ard Biesheuvel
	<ardb@...nel.org>, Sami Tolvanen <samitolvanen@...gle.com>, Peter Zijlstra
	<peterz@...radead.org>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>, Andrew
 Morton <akpm@...ux-foundation.org>, Dan Carpenter <dan.carpenter@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "live-patching@...r.kernel.org"
	<live-patching@...r.kernel.org>, Roman Gushchin <roman.gushchin@...ux.dev>,
	"Toshiyuki Sato (Fujitsu)" <fj6611ie@...itsu.com>
Subject: RE: [PATCH v4 0/2] livepatch, arm64/module: Enable late module
 relocations.

Hi Dylan,

> Late relocations (after the module is initially loaded) are needed when
> livepatches change module code. This is supported by x86, ppc, and s390.
> This series borrows the x86 methodology to reach the same level of support on
> arm64, and moves the text-poke locking into the core livepatch code to reduce
> redundancy.
> 
> Dylan Hatch (2):
>   livepatch, x86/module: Generalize late module relocation locking.
>   arm64/module: Use text-poke API for late relocations.
> 
>  arch/arm64/kernel/module.c | 113
> ++++++++++++++++++++++---------------
>  arch/x86/kernel/module.c   |   8 +--
>  kernel/livepatch/core.c    |  18 ++++--
>  3 files changed, 84 insertions(+), 55 deletions(-)
> 
> --
> 2.49.0.1151.ga128411c76-goog

Thanks for posting the new patch.

I ran kpatch's integration tests and no issues were detected.

The livepatch patches [1][2] (Manually adjusting arch/arm64/Kconfig) have been applied to the kernel (6.15-rc7).
The kpatch uses the same one as the previous test [3][4].

[1] https://lore.kernel.org/all/20250521111000.2237470-1-mark.rutland@arm.com/
[2] https://lore.kernel.org/all/20250320171559.3423224-3-song@kernel.org/
[3] https://lore.kernel.org/all/TY4PR01MB1377739F1CC08549A619C8635D7BA2@TY4PR01MB13777.jpnprd01.prod.outlook.com/
[4] https://github.com/dynup/kpatch/pull/1439

Tested-by: Toshiyuki Sato <fj6611ie@...jp.fujitsu.com>

Regards,
Toshiyuki Sato