linux-kernel - Re: [PATCH v5 1/4] dt-bindings: can: rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf6d6088-dacf-42d9-b8dc-92b6b17282a9@kernel.org>
Date: Fri, 23 May 2025 10:05:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Elaine Zhang <zhangqing@...k-chips.com>, mkl@...gutronix.de,
 kernel@...gutronix.de, mailhol.vincent@...adoo.fr, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de, cl@...k-chips.com,
 kever.yang@...k-chips.com
Cc: linux-can@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: can: rockchip_canfd: add rk3576
 CAN-FD controller

On 23/05/2025 09:54, Elaine Zhang wrote:
>        - items:
>            - const: rockchip,rk3568v3-canfd
>            - const: rockchip,rk3568v2-canfd
> @@ -43,6 +44,13 @@ properties:
>        - const: core
>        - const: apb
>  
> +  dmas:
> +    maxItems: 1
> +
> +  dma-names:
> +    items:
> +      - const: rx

All devices support DMA? If so, explain this in commit msg. If not, this
needs constraints per variant. See example-schema and other bindings.

> +
>  required:
>    - compatible
>    - reg
> @@ -72,3 +80,19 @@ examples:
>              reset-names = "core", "apb";
>          };
>      };
> +
> +  - |
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        can@...00000 {
> +            compatible = "rockchip,rk3576-canfd";

That's the same example. Drop.



Best regards,
Krzysztof