linux-kernel - RE: [PATCH v5 21/29] iommufd: Allow an input data_type via iommu_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276909836BDADF0F36005AB8C98A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Fri, 23 May 2025 08:06:54 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Nicolin Chen <nicolinc@...dia.com>, "jgg@...dia.com" <jgg@...dia.com>,
	"corbet@....net" <corbet@....net>, "will@...nel.org" <will@...nel.org>
CC: "bagasdotme@...il.com" <bagasdotme@...il.com>, "robin.murphy@....com"
	<robin.murphy@....com>, "joro@...tes.org" <joro@...tes.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>, "vdumpa@...dia.com"
	<vdumpa@...dia.com>, "jonathanh@...dia.com" <jonathanh@...dia.com>,
	"shuah@...nel.org" <shuah@...nel.org>, "jsnitsel@...hat.com"
	<jsnitsel@...hat.com>, "nathan@...nel.org" <nathan@...nel.org>,
	"peterz@...radead.org" <peterz@...radead.org>, "Liu, Yi L"
	<yi.l.liu@...el.com>, "mshavit@...gle.com" <mshavit@...gle.com>,
	"praan@...gle.com" <praan@...gle.com>, "zhangzekun11@...wei.com"
	<zhangzekun11@...wei.com>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>, "mochs@...dia.com" <mochs@...dia.com>,
	"alok.a.tiwari@...cle.com" <alok.a.tiwari@...cle.com>, "vasant.hegde@....com"
	<vasant.hegde@....com>, "dwmw2@...radead.org" <dwmw2@...radead.org>,
	"baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>
Subject: RE: [PATCH v5 21/29] iommufd: Allow an input data_type via
 iommu_hw_info

> From: Nicolin Chen <nicolinc@...dia.com>
> Sent: Sunday, May 18, 2025 11:22 AM
> 
> The iommu_hw_info can output via the out_data_type field the vendor data
> type from a driver, but this only allows driver to report one data type.
> 
> Now, with SMMUv3 having a Tegra241 CMDQV implementation, it has two
> sets
> of types and data structs to report.
> 
> One way to support that is to use the same type field bidirectionally.
> 
> Rename "out_data_type" to simply "data_type", to allow an input for user
> space to request for a specific type and to get the corresponding data.
> 
> For backward compatibility, since the ioctl handler has never checked an
> input value, add a new IOMMU_HW_INFO_FLAG_INPUT_TYPE to switch
> between
> the old output-only field and the new bidirectional field.
> 
> Signed-off-by: Nicolin Chen <nicolinc@...dia.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>