linux-kernel - Re: [PATCH] mm/hugetlb: remove redundant folio_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A1F5AF70-6C43-49A2-943E-CCCE62BA6A8E@linux.dev>
Date: Fri, 23 May 2025 16:30:15 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: yangge1116@....com
Cc: akpm@...ux-foundation.org,
 linux-mm@...ck.org,
 linux-kernel@...r.kernel.org,
 21cnbao@...il.com,
 david@...hat.com,
 baolin.wang@...ux.alibaba.com,
 osalvador@...e.de,
 liuzixing@...on.cn
Subject: Re: [PATCH] mm/hugetlb: remove redundant folio_test_hugetlb



> On May 23, 2025, at 16:05, yangge1116@....com wrote:
> 
> From: Ge Yang <yangge1116@....com>
> 
> In the isolate_or_dissolve_huge_folio() function, the folio_test_hugetlb()
> function is called to determine whether a folio is a hugetlb folio.
> However, in the subsequent alloc_and_dissolve_hugetlb_folio() function,
> the folio_test_hugetlb() function is called again to make the same
> determination about whether the folio is a hugetlb folio. It appears that
> the folio_test_hugetlb() check in the isolate_or_dissolve_huge_folio()
> function can be removed. Additionally, a similar issue exists in the
> replace_free_hugepage_folios() function, and it should be addressed as
> well.
> 
> Suggested-by: Oscar Salvador <osalvador@...e.de>
> Signed-off-by: Ge Yang <yangge1116@....com <mailto:yangge1116@....com>>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>

Thanks.