linux-kernel - Re: [PATCH 1/1] container_of: Document container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025052306-childlike-operating-d9c7@gregkh>
Date: Fri, 23 May 2025 10:36:45 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: David Laight <david.laight.linux@...il.com>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] container_of: Document container_of() is not to be
 used in new code

On Thu, May 22, 2025 at 10:01:42PM +0100, David Laight wrote:
> On Wed, 21 May 2025 15:31:36 +0200
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> > On Wed, May 21, 2025 at 03:27:19PM +0200, Greg Kroah-Hartman wrote:
> ...
> > I tried it for the whole tree, and ugh, there are some real "errors" in
> > there.  The nfs inode handling logic is crazy, passing in a const
> > pointer and then setting fields in it.  So this will be some real work
> > to unwind and fix in some places.
> 
> Perhaps change the really dodgy ones to container_of_deconst().
> And fix the easy ones so they compile with the 'const' check.

Ick, no, let me fix these up properly.  I'm picking them off, and have
found some real issues here.  It will give me something to build patches
for over time while doing stable kernel test builds :)

thanks,

greg k-h