linux-kernel - Re: [PATCH 2/2] clock: eswin: Add eic7700 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d8065ee-f8d1-4453-858b-485f7a5216de@kernel.org>
Date: Fri, 23 May 2025 11:15:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: dongxuyang@...incomputing.com, mturquette@...libre.com, sboyd@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: ningyu@...incomputing.com, linmin@...incomputing.com,
 huangyifeng@...incomputing.com
Subject: Re: [PATCH 2/2] clock: eswin: Add eic7700 clock driver

On 16/05/2025 15:23, Krzysztof Kozlowski wrote:
> On 14/05/2025 02:26, dongxuyang@...incomputing.com wrote:
>>> +static int eswin_cpu_clk_init(struct platform_device *pdev)
>> +{
>> +	struct clk *cpu_clk;
>> +	struct device *dev = &pdev->dev;
>> +	struct device_node *np = dev->of_node;
>> +	u32 default_freq;
>> +	int ret = 0;
>> +	int numa_id;
>> +	char name[128] = { 0 };
>> +
>> +	ret = of_property_read_u32(np, "cpu-default-frequency", &default_freq);
> 
> NAK, undocumented ABI.

I NAKed your patch and this you translated as reviewed? This is
inappropriate. You just bypass comments and force push your code onto us.


Best regards,
Krzysztof