linux-kernel - Re: [PATCH] drm/i915/display: Use str_true

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ee0e214018c1a0cdf279cef5dabd4851a12a647@intel.com>
Date: Fri, 23 May 2025 13:41:14 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: long.yunjian@....com.cn
Cc: rodrigo.vivi@...el.com, joonas.lahtinen@...ux.intel.com,
 tursulin@...ulin.net, airlied@...il.com, simona@...ll.ch,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 mou.yi@....com.cn, xu.lifeng1@....com.cn, fang.yumeng@....com.cn,
 ouyang.maochun@....com.cn
Subject: Re: [PATCH] drm/i915/display: Use str_true_false() helper

On Fri, 23 May 2025, <long.yunjian@....com.cn> wrote:
> From: Yumeng Fang <fang.yumeng@....com.cn>
>
> Remove hard-coded strings by using the str_true_false() helper.
>
> Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn>
> Signed-off-by: Yunjian Long <long.yunjian@....com.cn>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 8d0a1779dd19..0e3e62468902 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -5,6 +5,7 @@
>
>  #include <linux/debugfs.h>
>  #include <linux/string_helpers.h>
> +#include <linux/string_choices.h>
>
>  #include <drm/drm_debugfs.h>
>  #include <drm/drm_drv.h>
> @@ -972,7 +973,7 @@ static ssize_t i915_dsc_fec_support_write(struct file *file,
>  		return ret;
>
>  	drm_dbg(display->drm, "Got %s for DSC Enable\n",
> -		(dsc_enable) ? "true" : "false");
> +		str_true_false(dsc_enable));
>  	intel_dp->force_dsc_en = dsc_enable;
>
>  	*offp += len;
> @@ -1183,7 +1184,7 @@ static ssize_t i915_dsc_fractional_bpp_write(struct file *file,
>  		return ret;
>
>  	drm_dbg(display->drm, "Got %s for DSC Fractional BPP Enable\n",
> -		(dsc_fractional_bpp_enable) ? "true" : "false");
> +		str_true_false(dsc_fractional_bpp_enable));
>  	intel_dp->force_dsc_fractional_bpp_en = dsc_fractional_bpp_enable;
>
>  	*offp += len;

-- 
Jani Nikula, Intel