linux-kernel - Re: [PATCH v2] crypto: qat - add missing header inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDBbpOtpr5ATk4Rj@gondor.apana.org.au>
Date: Fri, 23 May 2025 19:27:32 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
Cc: Arnd Bergmann <arnd@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Karthikeyan Gopal <karthikeyan.gopal@...el.com>,
	Laurent M Coquerel <laurent.m.coquerel@...el.com>,
	Suman Kumar Chakraborty <suman.kumar.chakraborty@...el.com>,
	Arnd Bergmann <arnd@...db.de>,
	George Abraham P <george.abraham.p@...el.com>, qat-linux@...el.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] crypto: qat - add missing header inclusion

On Thu, May 22, 2025 at 11:21:41AM +0100, Cabiddu, Giovanni wrote:
>
> Without this header, the build of the new qat_6xxx driver fails when
> CONFIG_PCI_IOV is not set:
> 
>     In file included from drivers/crypto/intel/qat/qat_common/adf_gen6_shared.c:7:
>     drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h: In function 'adf_gen4_init_pf_pfvf_ops':
>     drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h:13:34: error: 'adf_pfvf_comms_disabled' undeclared (first use in this function)
>        13 |         pfvf_ops->enable_comms = adf_pfvf_comms_disabled;
>           |                                  ^~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
> ---
>  drivers/crypto/intel/qat/qat_common/adf_gen2_pfvf.h | 1 +
>  drivers/crypto/intel/qat/qat_common/adf_gen4_pfvf.h | 1 +
>  2 files changed, 2 insertions(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt