linux-kernel - Re: crypto: marvell/cesa - dma_alloc_coherent broken but kmalloc + dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDBgLT7NsMaG6ylh@gondor.apana.org.au>
Date: Fri, 23 May 2025 19:46:53 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Corentin Labbe <clabbe.montjoie@...il.com>
Cc: Klaus Kudielka <klaus.kudielka@...il.com>,
	Eric Biggers <ebiggers@...nel.org>, regressions@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	EBALARD Arnaud <Arnaud.Ebalard@....gouv.fr>,
	Romain Perier <romain.perier@...il.com>,
	Arnd Bergmann <arnd@...db.de>, Andrew Lunn <andrew@...n.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Gregory Clement <gregory.clement@...tlin.com>,
	Christoph Hellwig <hch@...radead.org>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Subject: Re: crypto: marvell/cesa - dma_alloc_coherent broken but kmalloc +
 dma_map_single works

On Thu, May 22, 2025 at 10:07:54PM +0200, Corentin Labbe wrote:
>
> Here is the result:
> http://kernel.montjoie.ovh/479404.log

So the corruptions have come back, although somewhat less than
before as one algorithm managed to pass all the tests.

At least we've proven that adding the printk's makes the errors
a lot more frequent :)

> I have built by adding also your "crypto: marvell/cesa - Fix engine load inaccuracy"

That shouldn't affect things either way.

So now all the corruptions are all on the final hash.

Can you boot this a few times to see if the errors are always
the same? I'm particularly interested to see if we've managed
to crush the errors on the partial hashes or was it just pure
luck.

Intriguingly the one error that went away (sha256) was actually
a partial hash corruption, and sha256 now passes all the tests.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt