linux-kernel - Re: mips gcc-12 malta_defconfig 'SOCK_COREDUMP' undeclared (first use in this function); did you mean 'SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+G9fYs1FMx6Z23i8g-yM-cABvZ4yTmPhfpRs4R1LBoP7Cyo5Q@mail.gmail.com>
Date: Fri, 23 May 2025 17:45:56 +0530
From: Naresh Kamboju <naresh.kamboju@...aro.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: linux-fsdevel@...r.kernel.org, linux-mips@...r.kernel.org, 
	open list <linux-kernel@...r.kernel.org>, lkft-triage@...ts.linaro.org, 
	Linux Regressions <regressions@...ts.linux.dev>, 
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Anders Roxell <anders.roxell@...aro.org>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, 
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: mips gcc-12 malta_defconfig 'SOCK_COREDUMP' undeclared (first use
 in this function); did you mean 'SOCK_RDM'?

Hi Arnd,

On Thu, 22 May 2025 at 19:32, Arnd Bergmann <arnd@...db.de> wrote:
>
> On Thu, May 22, 2025, at 15:22, Naresh Kamboju wrote:
>
> > ## Build log
> > net/unix/af_unix.c: In function 'unix_find_bsd':
> > net/unix/af_unix.c:1152:21: error: 'SOCK_COREDUMP' undeclared (first
> > use in this function); did you mean 'SOCK_RDM'?
> >  1152 |         if (flags & SOCK_COREDUMP) {
>
> SOCK_COREDUMP should be defined outside of ARCH_HAS_SOCKET_TYPES.
> How about reducing the scope of that check like this?
>
>       Arnd
>

Thanks for sharing a quick fix patch.
This below patch is applied and build test pass.

Tested-by: Naresh Kamboju  <naresh.kamboju@...aro.org>


> diff --git a/arch/mips/include/asm/socket.h b/arch/mips/include/asm/socket.h
> index 4724a563c5bf..43a09f0dd3ff 100644
> --- a/arch/mips/include/asm/socket.h
> +++ b/arch/mips/include/asm/socket.h
> @@ -36,15 +36,6 @@ enum sock_type {
>         SOCK_PACKET     = 10,
>  };
>
> -#define SOCK_MAX (SOCK_PACKET + 1)
> -/* Mask which covers at least up to SOCK_MASK-1.  The
> - *  * remaining bits are used as flags. */
> -#define SOCK_TYPE_MASK 0xf
> -
> -/* Flags for socket, socketpair, paccept */
> -#define SOCK_CLOEXEC   O_CLOEXEC
> -#define SOCK_NONBLOCK  O_NONBLOCK
> -
>  #define ARCH_HAS_SOCKET_TYPES 1
>
>  #endif /* _ASM_SOCKET_H */
> diff --git a/include/linux/net.h b/include/linux/net.h
> index 139c85d0f2ea..f60fff91e1df 100644
> --- a/include/linux/net.h
> +++ b/include/linux/net.h
> @@ -70,6 +70,7 @@ enum sock_type {
>         SOCK_DCCP       = 6,
>         SOCK_PACKET     = 10,
>  };
> +#endif /* ARCH_HAS_SOCKET_TYPES */
>
>  #define SOCK_MAX (SOCK_PACKET + 1)
>  /* Mask which covers at least up to SOCK_MASK-1.  The
> @@ -83,8 +84,6 @@ enum sock_type {
>  #endif
>  #define SOCK_COREDUMP  O_NOCTTY
>
> -#endif /* ARCH_HAS_SOCKET_TYPES */
> -
>  /**
>   * enum sock_shutdown_cmd - Shutdown types
>   * @SHUT_RD: shutdown receptions
>
>