linux-kernel - Re: [PATCH 1/3] dt-bindings: spi: Add bindings for SOPHGO SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174800295404.1369155.8184258827735093868.robh@kernel.org>
Date: Fri, 23 May 2025 07:22:34 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Zixian Zeng <sycamoremoon376@...il.com>
Cc: Richard Weinberger <richard@....at>, 
 Chen Wang <unicorn_wang@...look.com>, Conor Dooley <conor+dt@...nel.org>, 
 Mark Brown <broonie@...nel.org>, linux-riscv@...ts.infradead.org, 
 devicetree@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Albert Ou <aou@...s.berkeley.edu>, Tudor Ambarus <tudor.ambarus@...aro.org>, 
 Inochi Amaoto <inochiama@...il.com>, linux-kernel@...r.kernel.org, 
 Alexandre Ghiti <alex@...ti.fr>, dlan@...too.org, 
 Miquel Raynal <miquel.raynal@...tlin.com>, 
 Vignesh Raghavendra <vigneshr@...com>, sophgo@...ts.linux.dev, 
 linux-mtd@...ts.infradead.org, linux-spi@...r.kernel.org, 
 Longbin Li <looong.bin@...il.com>, ziyao@...root.org, 
 Paul Walmsley <paul.walmsley@...ive.com>, Michael Walle <mwalle@...nel.org>, 
 Pratyush Yadav <pratyush@...nel.org>, Palmer Dabbelt <palmer@...belt.com>
Subject: Re: [PATCH 1/3] dt-bindings: spi: Add bindings for SOPHGO SG2042


On Fri, 23 May 2025 18:54:49 +0800, Zixian Zeng wrote:
> Add bindings for the SOPHGO SG2042 SPI-NOR flash controller,
> which is compatible with SOPHGO SG2044.
> 
> Signed-off-by: Zixian Zeng <sycamoremoon376@...il.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/spi/spi-sg2044-nor.yaml:20:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.example.dtb: spi@...0000 (sophgo,sg2044-spifmc-nor): compatible:0: 'sophgo,sg2044-spifmc-nor' is not one of ['sophgo,sg2042-spifmc-nor']
	from schema $id: http://devicetree.org/schemas/spi/spi-sg2044-nor.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.example.dtb: spi@...0000 (sophgo,sg2044-spifmc-nor): compatible: ['sophgo,sg2044-spifmc-nor'] is too short
	from schema $id: http://devicetree.org/schemas/spi/spi-sg2044-nor.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/spi-sg2044-nor.example.dtb: spi@...0000 (sophgo,sg2044-spifmc-nor): Unevaluated properties are not allowed ('compatible' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/spi-sg2044-nor.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250523-sfg-spifmc-v1-1-4cf16cf3fd2a@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.