linux-kernel - Re: [PATCH v4 3/5] dt-bindings: power: supply: add max77759-fg flavor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174801020213.1711113.345093338339691791.robh@kernel.org>
Date: Fri, 23 May 2025 09:23:23 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Thomas Antoine <t.antoine@...ouvain.be>
Cc: linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 André Draszik <andre.draszik@...aro.org>, 
 Will Deacon <will@...nel.org>, Tudor Ambarus <tudor.ambarus@...aro.org>, 
 linux-kernel@...r.kernel.org, Peter Griffin <peter.griffin@...aro.org>, 
 Dimitri Fedrau <dima.fedrau@...il.com>, 
 Alim Akhtar <alim.akhtar@...sung.com>, Sebastian Reichel <sre@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, 
 linux-samsung-soc@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, 
 Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH v4 3/5] dt-bindings: power: supply: add max77759-fg
 flavor


On Fri, 23 May 2025 14:51:46 +0200, Thomas Antoine wrote:
> The Maxim MAX77759 is an IC used to manage the power supply of the battery
> and the USB-C. Based on drivers from google, it contains at least a PMIC,
> a fuel gauge, a TCPCI and a charger.
> 
> Use max77759-fg compatible to avoid conflict with drivers for other
> functions.
> 
> The Maxim MAX77759 has no non-volatile memory so it doesn't require an
> address and instead requires a value for the current sensing resistor.
> 
> Keep shunt-resistor-micro-ohms optional for the MAX17201/MAX17205 as it is
> not be used at the moment but could be in the future. (e.g. as a default
> value to be used in case of nvmem failure)
> 
> Signed-off-by: Thomas Antoine <t.antoine@...ouvain.be>
> ---
>  .../bindings/power/supply/maxim,max17201.yaml      | 42 ++++++++++++++++++++--
>  1 file changed, 39 insertions(+), 3 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml: properties:reg: {'items': [{'description': 'ModelGauge m5 registers'}, {'description': 'Nonvolatile registers'}], 'minItems': 1, 'maxItems': 2} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/maxim,max17201.yaml: properties:reg-names: {'items': [{'const': 'm5'}, {'const': 'nvmem'}], 'minItems': 1, 'maxItems': 2} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250523-b4-gs101_max77759_fg-v4-3-b49904e35a34@uclouvain.be

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.