linux-kernel - Re: [PATCH 2/2] ACPI: bus: Bail out if acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h91htjq4JzMkL3+K-oE1Zw+s5dvR5WPWnesSi7=97Eww@mail.gmail.com>
Date: Fri, 23 May 2025 16:56:38 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Armin Wolf <W_Armin@....de>
Cc: rafael@...nel.org, lenb@...nel.org, j@...nau.net, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ACPI: bus: Bail out if acpi_kobj registration fails

On Sun, May 18, 2025 at 8:51 PM Armin Wolf <W_Armin@....de> wrote:
>
> The ACPI sysfs code will fail to initialize if acpi_kobj is NULL,
> together with some ACPI drivers. Follow the other firmware subsystems
> and bail out if the kobject cannot be registered.
>
> Signed-off-by: Armin Wolf <W_Armin@....de>
> ---
>  drivers/acpi/bus.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 058910af82bc..c2ab2783303f 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -1446,8 +1446,10 @@ static int __init acpi_init(void)
>         }
>
>         acpi_kobj = kobject_create_and_add("acpi", firmware_kobj);
> -       if (!acpi_kobj)
> -               pr_debug("%s: kset create error\n", __func__);
> +       if (!acpi_kobj) {
> +               pr_err("Failed to register kobject\n");
> +               return -ENOMEM;
> +       }
>
>         init_prmt();
>         acpi_init_pcc();
> --

Applied as 6.16 material, thanks!