linux-kernel - Re: [PATCH] kernel/sysctl-test: Unregister sysctl table after test completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yaadrvxr76up6j2cixi5hhrxrb4yd6rfus7n3pvh3fv42ahk32@vwiphrfdvj57>
Date: Fri, 23 May 2025 17:01:36 +0200
From: Joel Granados <joel.granados@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, Wen Yang <wen.yang@...ux.dev>
Subject: Re: [PATCH] kernel/sysctl-test: Unregister sysctl table after test
 completion

On Thu, May 22, 2025 at 11:53:15AM -0700, Guenter Roeck wrote:
> On Wed, May 21, 2025 at 06:32:11PM -0700, Guenter Roeck wrote:
> > One of the sysctl tests registers a valid sysctl table. This operation
> > is expected to succeed. However, it does not unregister the table after
> > executing the test. If the code is built as module and the module is
> > unloaded after the test, the next operation trying to access the table
> > (such as 'sysctl -a') will trigger a crash.
> > 
> > Unregister the registered table after test completiion to solve the
> > problem.
> > 
> 
> Never mind, I just learned that a very similar patch has been submitted
> last December or so but was rejected, and that the acceptable (?) fix seems
> to be stalled.
> 
> Sorry for the noise.
> 
> Guenter

Hey Guenter

It is part of what is getting sent for 6.16 [1]
That test will move out of kunit into self-test.

Best


[1] https://sysctl-dev-rtd.readthedocs.io/en/latest/release.html#patch-0-4-sysctl-move-the-u8-range-check-test-to-lib-test-sysctl-c

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)