linux-kernel - Re: [PATCH v2] arm64: dts: freescale: imx93-phycore-som: Delay the phy reset by a gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ea4f86ff4ecf6affc55f0fe11c368bfad9d91b2.camel@phytec.de>
Date: Sat, 24 May 2025 11:25:54 +0000
From: Christoph Stoidner <C.Stoidner@...tec.de>
To: Fabio Estevam <festevam@...il.com>
CC: Primoz Fiser <primoz.fiser@...ik.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "upstream@...ts.phytec.de"
	<upstream@...ts.phytec.de>
Subject: Re: [PATCH v2] arm64: dts: freescale: imx93-phycore-som: Delay the
 phy reset by a gpio

On Mi, 2025-05-21 at 14:01 +0200, Christoph Stoidner wrote:
> On Di, 2025-05-20 at 10:34 -0300, Fabio Estevam wrote:
> > On Tue, May 20, 2025 at 8:52 AM Christoph Stoidner
> > <c.stoidner@...tec.de> wrote:
> > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
> > > index 88c2657b50e6..c08f4b8a65a6 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
> > > @@ -58,6 +58,9 @@ &fec {
> > >                                  <&clk
> > > IMX93_CLK_SYS_PLL_PFD1_DIV2>,
> > >                                  <&clk
> > > IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> > >         assigned-clock-rates = <100000000>, <50000000>,
> > > <50000000>;
> > > +       phy-reset-gpios = <&gpio4 23 GPIO_ACTIVE_HIGH>;
> > > +       phy-reset-duration = <1>;
> > > +       phy-reset-post-delay = <0>;
> > 
> > These properties are marked as deprecated in fsl,fec.yaml.
> > 
> > It would be better to place the properties described by
> > ethernet-phy.yaml under the ethernet-phy@1 node.
> 
> Ok, I need to double-check that these do work properly in
> u-boot on our platform. I will come back here.

Checked, it work. I will send a v3 for it.

Regards,
Christoph