[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<VI1P195MB02721791E42104B050912965979BA@VI1P195MB0272.EURP195.PROD.OUTLOOK.COM>
Date: Sat, 24 May 2025 21:37:17 +0000
From: Christoph Stoidner <C.Stoidner@...tec.de>
To: Andrew Lunn <andrew@...n.ch>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "upstream@...ts.phytec.de"
<upstream@...ts.phytec.de>
Subject: AW: [PATCH v3] arm64: dts: freescale: imx93-phycore-som: Delay the
phy reset by a gpio
Hi Andrew,
> On Di, 2025-05-24 at 19:44 -0300, Andrew Lunn wrote:
>
>> diff --git a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
>> index 88c2657b50e6..b481097f08a4 100644
>> --- a/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx93-phycore-som.dtsi
>> @@ -68,6 +68,8 @@ mdio: mdio {
>> ethphy1: ethernet-phy@1 {
>> compatible = "ethernet-phy-ieee802.3-c22";
>> reg = <1>;
>> + reset-gpios = <&gpio4 23 GPIO_ACTIVE_HIGH>;
>> + reset-assert-us = <30>;
>
>Is there anything in the datasheet about needing a delay after the
>reset? There is a DT property for this:
>
> reset-deassert-us:
> description:
> Delay after the reset was deasserted in microseconds. If
> this property is missing the delay will be skipped.
No, there is no need for a delay after the reset mentioned in the datasheet.
There is only the delay after the assert (i.E. the pulse width), that I
declared with the property reset-assert-us.
>
>Anyway:
>
>Reviewed-by: Andrew Lunn <andrew@...n.ch>
Thanks, and regards,
Christoph
>
> Andrew
Powered by blists - more mailing lists