linux-kernel - Re: [PATCH V2 1/2] mm/khugepaged: clean up refcount check using folio_expected_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1e9bfec-fdd1-4512-a115-6109d99cbb8a@redhat.com>
Date: Sat, 24 May 2025 23:47:28 +0200
From: David Hildenbrand <david@...hat.com>
To: Shivank Garg <shivankg@....com>, akpm@...ux-foundation.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: ziy@...dia.com, baolin.wang@...ux.alibaba.com,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, npache@...hat.com,
 ryan.roberts@....com, dev.jain@....com, fengwei.yin@...el.com,
 bharata@....com
Subject: Re: [PATCH V2 1/2] mm/khugepaged: clean up refcount check using
 folio_expected_ref_count()

On 23.05.25 11:14, Shivank Garg wrote:
> Use folio_expected_ref_count() instead of open-coded logic in
> is_refcount_suitable(). This avoids code duplication and improves
> clarity.
> 
> Drop is_refcount_suitable() as it is no longer needed.
> 
> Suggested-by: David Hildenbrand <david@...hat.com>
> Signed-off-by: Shivank Garg <shivankg@....com>
> ---

Likely we should revert the patches, so we can have the fix in first.

So in this patch here, we would only convert the remaining 2 instances.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb