linux-kernel - Re: [PATCH 2/2] PCI: Rename host_bridge::reset_slot() to host_bridge::reset_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505250525.2csmeURe-lkp@intel.com>
Date: Sun, 25 May 2025 05:51:12 +0800
From: kernel test robot <lkp@...el.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	cassel@...nel.org, wilfred.mallawa@....com,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH 2/2] PCI: Rename host_bridge::reset_slot() to
 host_bridge::reset_root_port()

Hi Manivannan,

kernel test robot noticed the following build errors:

[auto build test ERROR on pci/next]
[also build test ERROR on next-20250523]
[cannot apply to pci/for-linus linus/master v6.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam/PCI-Save-and-restore-root-port-config-space-in-pcibios_reset_secondary_bus/20250525-025535
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250524185304.26698-3-manivannan.sadhasivam%40linaro.org
patch subject: [PATCH 2/2] PCI: Rename host_bridge::reset_slot() to host_bridge::reset_root_port()
config: csky-randconfig-002-20250525 (https://download.01.org/0day-ci/archive/20250525/202505250525.2csmeURe-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250525/202505250525.2csmeURe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505250525.2csmeURe-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/pci/controller/dwc/pcie-dw-rockchip.c: In function 'rockchip_pcie_host_init':
>> drivers/pci/controller/dwc/pcie-dw-rockchip.c:264:32: error: 'rockchip_pcie_rc_reset_slot' undeclared (first use in this function); did you mean 'rockchip_pcie_rc_reset_root_port'?
     264 |  pp->bridge->reset_root_port = rockchip_pcie_rc_reset_slot;
         |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                                rockchip_pcie_rc_reset_root_port
   drivers/pci/controller/dwc/pcie-dw-rockchip.c:264:32: note: each undeclared identifier is reported only once for each function it appears in
   At top level:
>> drivers/pci/controller/dwc/pcie-dw-rockchip.c:703:12: warning: 'rockchip_pcie_rc_reset_root_port' defined but not used [-Wunused-function]
     703 | static int rockchip_pcie_rc_reset_root_port(struct pci_host_bridge *bridge,
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +264 drivers/pci/controller/dwc/pcie-dw-rockchip.c

   244	
   245	static int rockchip_pcie_host_init(struct dw_pcie_rp *pp)
   246	{
   247		struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
   248		struct rockchip_pcie *rockchip = to_rockchip_pcie(pci);
   249		struct device *dev = rockchip->pci.dev;
   250		int irq, ret;
   251	
   252		irq = of_irq_get_byname(dev->of_node, "legacy");
   253		if (irq < 0)
   254			return irq;
   255	
   256		ret = rockchip_pcie_init_irq_domain(rockchip);
   257		if (ret < 0)
   258			dev_err(dev, "failed to init irq domain\n");
   259	
   260		irq_set_chained_handler_and_data(irq, rockchip_pcie_intx_handler,
   261						 rockchip);
   262	
   263		rockchip_pcie_enable_l0s(pci);
 > 264		pp->bridge->reset_root_port = rockchip_pcie_rc_reset_slot;
   265	
   266		return 0;
   267	}
   268	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki