linux-kernel - Re: [PATCH 09/18] media: coda: Fix max h.264 level for CODA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4ced91cbc1e52347189a91351fcde17f021bc09.camel@ndufresne.ca>
Date: Fri, 23 May 2025 20:07:04 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Sergey Khimich <serghox@...il.com>, linux-media@...r.kernel.org
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Mauro Carvalho Chehab
	 <mchehab@...nel.org>, linux-kernel@...r.kernel.org, Vladimir Yakovlev
	 <vovchkir@...il.com>, Maksim Turok <turok.m7@...il.com>
Subject: Re: [PATCH 09/18] media: coda: Fix max h.264 level for CODA_DX6

Hi,

Le vendredi 14 mars 2025 à 18:29 +0300, Sergey Khimich a écrit :
> From: Vladimir Yakovlev <vovchkir@...il.com>
> 
> CODA_DX6 has h.264 decoder but v4l2_ctrls of level wasn't setting

Perhaps:
CODA_DX6 supports H.264 decoder, though the maximum level wasn't set
properly.

regards,
Nicolas

> for this device.

> 
> Co-developed-by: Sergey Khimich <serghox@...il.com>
> Signed-off-by: Sergey Khimich <serghox@...il.com>
> Signed-off-by: Vladimir Yakovlev <vovchkir@...il.com>
> ---
>  drivers/media/platform/chips-media/coda/coda-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-
> common.c
> index 33c7e8398f31..555b73816952 100644
> --- a/drivers/media/platform/chips-media/coda/coda-common.c
> +++ b/drivers/media/platform/chips-media/coda/coda-common.c
> @@ -2440,8 +2440,8 @@ static void coda_decode_ctrls(struct coda_ctx *ctx)
>  		max = V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
>  	else if (ctx->dev->devtype->product == CODA_960)
>  		max = V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
> -	else
> -		return;
> +	else /* CODA_DX6 */
> +		max = V4L2_MPEG_VIDEO_H264_LEVEL_3_0;
>  	ctx->h264_level_ctrl = v4l2_ctrl_new_std_menu(&ctx->ctrls,
>  		&coda_ctrl_ops, V4L2_CID_MPEG_VIDEO_H264_LEVEL, max, 0, max);
>  	if (ctx->h264_level_ctrl)