linux-kernel - Re: [PATCH 4/5] dt-bindings: thermal: airoha: Rename and Document AN7583 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e19ee6c5-447e-43ee-bc63-df15ff2f6031@kernel.org>
Date: Sat, 24 May 2025 08:30:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: thermal: airoha: Rename and Document
 AN7583 support

On 23/05/2025 20:29, Christian Marangi wrote:
> Rename .yaml to a more generic airoha-thermal and Document support for
> Airoha AN7583 thermal driver.
> 
> Airoha AN7583 follow the same logic of Airoha EN7581 to read the
> temperature but lack all the support for the PTP_THERMAL used to monitor
> and react when trip point are triggered.
> 
> Also the Airoha AN7583 lives entirely under the Chip SCU SoC register
> space.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  ...n7581-thermal.yaml => airoha-thermal.yaml} | 42 ++++++++++++++++---
>  1 file changed, 36 insertions(+), 6 deletions(-)
>  rename Documentation/devicetree/bindings/thermal/{airoha,en7581-thermal.yaml => airoha-thermal.yaml} (52%)

No. I do not see any reason to rename correct filename (how we expect)
to incorrect (wrong format, no vendor prefix, not matching compatible).

> 
> diff --git a/Documentation/devicetree/bindings/thermal/airoha,en7581-thermal.yaml b/Documentation/devicetree/bindings/thermal/airoha-thermal.yaml
> similarity index 52%
> rename from Documentation/devicetree/bindings/thermal/airoha,en7581-thermal.yaml
> rename to Documentation/devicetree/bindings/thermal/airoha-thermal.yaml
> index ca0242ef0378..42f93b095783 100644
> --- a/Documentation/devicetree/bindings/thermal/airoha,en7581-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/airoha-thermal.yaml
> @@ -1,17 +1,19 @@
>  # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/thermal/airoha,en7581-thermal.yaml#
> +$id: http://devicetree.org/schemas/thermal/airoha-thermal.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Airoha EN7581 Thermal Sensor and Monitor
> +title: Airoha Thermal Sensor and Monitor
>  
>  maintainers:
>    - Christian Marangi <ansuelsmth@...il.com>
>  
>  properties:
>    compatible:
> -    const: airoha,en7581-thermal
> +    enum:
> +      - airoha,en7581-thermal
> +      - airoha,an7583-thermal
>  
>    reg:
>      maxItems: 1
> @@ -28,9 +30,30 @@ properties:
>  
>  required:
>    - compatible
> -  - reg
> -  - interrupts
> -  - airoha,chip-scu
> +  - '#thermal-sensor-cells'
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: airoha,en7581-thermal
> +    then:
> +      required:
> +        - reg
> +        - interrupts
> +        - airoha,chip-scu
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: airoha,an7583-thermal
> +    then:
> +      properties:
> +        reg: false

Don't stuff completely different devices into one binding. They are
completely different if they have completely different programming model.


Best regards,
Krzysztof